[GitHub] [superset] duynguyenhoang opened a new pull request #13713: fix: CSV Export Permission is incorrect on Explore page

Fri, 19 Mar 2021 10:57:28 -0700 


duynguyenhoang opened a new pull request #13713:
URL: https://github.com/apache/superset/pull/13713


   ### SUMMARY
   - Add CSV Export permission when exporting CSV.
   - Fix CSV Export permission on Expore page.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before
   
   
![Screenshot_20210320_005126](https://user-images.githubusercontent.com/7106179/111822519-7333ea00-8916-11eb-82df-c8dede9e5e14.png)
   After
   
![Screenshot_20210320_005059](https://user-images.githubusercontent.com/7106179/111822525-74651700-8916-11eb-9212-6994531eb95d.png)
   
   ### TEST PLAN
   - Log in with user without "Can CSV on Superset" permission.
   - Go to Dashboard page, verify there is no "Export CSV" in chart context 
menu.
   - Click "View chart in Explore", verify that "Export CSV" button is disabled 
and unclickable.
   - Try to access CSV export manually => 403 error returned with message `{ 
"error": "You don't have the rights to download as csv" }`
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: Fixed #13711
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to