[GitHub] [superset] eschutho opened a new pull request #13720: sort time grain configs

[GitBox]

eschutho opened a new pull request #13720:
URL: https://github.com/apache/superset/pull/13720


   ### SUMMARY
   When using the `TIME_GRAIN_ADDONS` and `TIME_GRAIN_ADDON_EXPRESSIONS` 
configs, the additional configs are normally just appended at the end in the 
dropdown selections. In order to format it as expected, this sorts the time 
grains in an order that it expects, and if a value is given that it doesn't 
expect, it puts it at the end. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   example with adding 2/4/6/8/10/12 hour time grains:
   
   <img width="365" alt="Screenshot_3_19_21__5_42_PM" 
src="https://user-images.githubusercontent.com/5186919/111855610-1cf98380-88e3-11eb-8f7b-52569f7cdb31.png";>
   <img width="344" alt="Screenshot_3_19_21__5_42_PM" 
src="https://user-images.githubusercontent.com/5186919/111855619-25ea5500-88e3-11eb-8e0e-7c96628d96d3.png";>
   <img width="348" alt="Screenshot_3_19_21__5_43_PM" 
src="https://user-images.githubusercontent.com/5186919/111855626-38648e80-88e3-11eb-870e-72016c3cc411.png";>
   
   
   ### TEST PLAN
   visual test and unit tests
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org