eschutho commented on a change in pull request #13676:
URL: https://github.com/apache/superset/pull/13676#discussion_r599175039
##########
File path: superset-frontend/src/SqlLab/components/SouthPane.tsx
##########
@@ -83,33 +77,34 @@ const StyledPane = styled.div`
}
`;
-export class SouthPane extends React.PureComponent {
- constructor(props) {
- super(props);
- this.southPaneRef = React.createRef();
- this.switchTab = this.switchTab.bind(this);
- }
+function SouthPane({
+ editorQueries,
+ latestQueryId,
+ dataPreviewQueries,
+ actions,
+ activeSouthPaneTab = 'Results',
+ height,
+ databases,
+ offline = false,
+ displayLimit,
+}: SouthPanePropTypes) {
+ const innerTabContentHeight = height - TAB_HEIGHT;
+ const southPaneRef: any = useRef();
Review comment:
more specific type here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
