villebro opened a new pull request #13769:
URL: https://github.com/apache/superset/pull/13769
### SUMMARY
The PR #13625 introduced a regression in the native filters feature, causing
existing filter configurations to not show up on the Filter Tab and making it
impossible to save affected dashboards. The reason for the regression was that
the `filter_configuration` property in the dashboard's `json_metadata` object
had changed name to `native_filter_configuraion`.
This PR migrates all existing dashboards that include native filter
configurations from using the now deprecated `filter_configuration` to the new
`native_filter_configuration`. Dashboards that were already using the new name
are unaffected. The migration also limits the migration to dashboards that have
native filter configurations, making this migration fairly light weight (won't
touch any rows if the native filters feature was not activated).
### TEST PLAN
- Tested that a dashboard with the old metadata failed to load and failed to
update metadata
- Tested up migration, and made sure it only modified dashboards with the
old `filter_configuration` property to use the new
`native_filter_configuration` property. Also made sure the dashboards loaded
the filter configurations correctly, and were able to to save new metadata.
- Tested down migration, and made sure it changed the dashboards to use the
old `filter_configuration` property. Also reran the up migration, and made sure
dashboards with native filters were working again.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
