michael-s-molina commented on pull request #13719: URL: https://github.com/apache/superset/pull/13719#issuecomment-806072101
> > @yardz About the comments.. one way to achieve the same objective of communicating the problems that you had, is to mark this PR as a draft and make the comments in the review section. This way we can iterate on each problem and keep the code clean 😉 > > I agree, but I think that in this context it is a little more complicated. If we are going to solve all the problems that I mentioned, I believe that PR will be gigantic. This file has several functions with very dangerous behaviors. I created the tests and skipped them just to warn of these behaviors. > > The idea here was to approve what can be tested but the tests are there to show some behaviors that can generate a bug. > > Changing the functions, adding typescript and improvements is not the goal now ... So I thought it best not to discuss this in this PR. If you think that the PR will be giant I suggest only keep in this PR the tests that are working and the code without those comments. Then open another PR with the problematic tests in draft mode. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
