rusackas commented on a change in pull request #13719: URL: https://github.com/apache/superset/pull/13719#discussion_r602028638
########## File path: superset-frontend/src/explore/exploreUtils/getChartKey.test.ts ########## @@ -0,0 +1,23 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { getChartKey } from '.'; + +test('should return 0 when called with complete object', () => { Review comment: Not sure what the title means here... if the assertion is that it returns 100, why is the test title saying 0? And the "when called with a complete object" title begs the question: are there times it may NOT be called in that condition that we should assert against? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
