dpgaspar commented on a change in pull request #13752:
URL: https://github.com/apache/superset/pull/13752#discussion_r602289761
##########
File path: superset/models/reports.py
##########
@@ -171,6 +172,7 @@ class ReportExecutionLog(Model): # pylint:
disable=too-few-public-methods
__tablename__ = "report_execution_log"
id = Column(Integer, primary_key=True)
+ uuid = Column(UUIDType(binary=True))
Review comment:
Without the use of celery's UUID, you can just use `default=uuid.uuid4`
We probably should think about moving out of sqlalchemy_utils...
##########
File path: superset/reports/commands/execute.py
##########
@@ -403,6 +407,7 @@ def __init__(
self._session = session
self._report_schedule = report_schedule
self._scheduled_dttm = scheduled_dttm
+ self._execution_id = uuid4()
Review comment:
Have you checked if we can use celery's UUID, and pass it into the
`AsyncExecuteReportScheduleCommand` constructor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
