yardz commented on pull request #13458: URL: https://github.com/apache/superset/pull/13458#issuecomment-808472140
> Thank you for the search. That's a strong indicator that in fact, we should have a `Fade` component in `src/components`. Can you paste the references here so we can close this PR and open a new one with the objective of creating this new Fade component and consolidating all the references? These components have some "fade behavior": - `src/dashboard/components/gridComponents/ChartHolder.jsx` - `src/chart/Chart.jsx` - `src/messageToasts/components/ToastPresenter.tsx` There are also "fade effects" in less files that I was unable to find the components that use them. Again, this search was very superficial (I searched for the name "fade" And I did a very simple reading of the code). If we look for "transition" + "opacity" effects, I believe we will find more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
