rusackas commented on a change in pull request #13794:
URL: https://github.com/apache/superset/pull/13794#discussion_r602631234
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterValue.tsx
##########
@@ -27,20 +27,15 @@ import {
} from '@superset-ui/core';
import { areObjectsEqual } from 'src/reduxUtils';
import { getChartDataRequest } from 'src/chart/chartAction';
-import Loading from 'src/components/Loading';
import BasicErrorAlert from 'src/components/ErrorMessage/BasicErrorAlert';
import { FilterProps } from './types';
import { getFormData } from '../../utils';
import { useCascadingFilters } from './state';
-
-const StyledLoadingBox = styled.div`
- position: relative;
- height: ${({ theme }) => theme.gridUnit * 8}px;
- margin-bottom: ${({ theme }) => theme.gridUnit * 6}px;
-`;
+import LoadingBox from '../LoadingBox';
const FilterItem = styled.div`
- padding-bottom: 10px;
+ min-height: ${({ theme }) => theme.gridUnit * 10.5}px;
+ padding-bottom: ${({ theme }) => theme.gridUnit * 2.5}px;
Review comment:
I'm hoping/trying to avoid fractional gridUnits if at all possible. I
know there are a few kicking around in the codebase, but (a) we should just
learn to stick to the grid for the sake of design's sanity, and (b) ththings
can get weird if gridUnit is ever moved to, say, 5px, and we find ourselves in
fractional-pixel land.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
