willbarrett commented on a change in pull request #13740:
URL: https://github.com/apache/superset/pull/13740#discussion_r603588885
##########
File path: superset/reports/commands/alert.py
##########
@@ -146,7 +146,8 @@ def _execute_query(self) -> pd.DataFrame:
rendered_sql, ALERT_SQL_LIMIT
)
return self._report_schedule.database.get_df(limited_rendered_sql)
- except SoftTimeLimitExceeded:
+ except SoftTimeLimitExceeded as ex:
+ logger.error("A timeout occurred while executing the alert query:
%s", ex)
Review comment:
I don't think we need to log the errors - this is somewhat expected
behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
