[GitHub] [superset] AAfghahi opened a new pull request #13858: fix: Floating Menu in SQL Left Bar

Mon, 29 Mar 2021 14:31:12 -0700 


AAfghahi opened a new pull request #13858:
URL: https://github.com/apache/superset/pull/13858


   ### SUMMARY
   The table and database selector were floating in SQL Left Bar. This solution 
fixes that by creating a new prop in TableSelector that determines whether to 
use a created ref or the document body. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:  
   
   
![image](https://user-images.githubusercontent.com/48933336/112902582-58027080-90b4-11eb-912b-62e84b47857c.png)
   
![image](https://user-images.githubusercontent.com/48933336/112902600-5df85180-90b4-11eb-95a0-cd815d32e801.png)
   
   
   After: 
   ![Screen Shot 2021-03-29 at 5 27 25 
PM](https://user-images.githubusercontent.com/48933336/112902613-63559c00-90b4-11eb-871f-a24110624739.png)
   ![Screen Shot 2021-03-29 at 5 27 29 
PM](https://user-images.githubusercontent.com/48933336/112902619-651f5f80-90b4-11eb-829a-263dea8c6978.png)
   
   ### TEST PLAN
   This was visually tested. 
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to