ktmud commented on a change in pull request #13859:
URL: https://github.com/apache/superset/pull/13859#discussion_r603705397
##########
File path: superset/viz.py
##########
@@ -439,7 +440,13 @@ def cache_key(self, query_obj: QueryObjectDict, **extra:
Any) -> str:
def get_payload(self, query_obj: Optional[QueryObjectDict] = None) ->
VizPayload:
"""Returns a payload of metadata and data"""
- self.run_extra_queries()
+ try:
+ self.run_extra_queries()
+ except SupersetSecurityException as ex:
Review comment:
Shouldn't this be captured by the global exception handler?
##########
File path: superset/viz.py
##########
@@ -439,7 +440,13 @@ def cache_key(self, query_obj: QueryObjectDict, **extra:
Any) -> str:
def get_payload(self, query_obj: Optional[QueryObjectDict] = None) ->
VizPayload:
"""Returns a payload of metadata and data"""
- self.run_extra_queries()
+ try:
+ self.run_extra_queries()
+ except SupersetSecurityException as ex:
Review comment:
Shouldn't this be captured by the global API exception handler?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
