EBoisseauSierra edited a comment on pull request #13852: URL: https://github.com/apache/superset/pull/13852#issuecomment-809997190
> will prophet 1.0.1 work with Superset? You are right that it's a better thing to do. Unfortunately, I hadn't much time to extensively test bumping `fbprophet<0.7` to `prophet>=1.01`, so — especially as I'm not so familiar with the codebase and that I couldn't find in [`7af8b2b3f`](https://github.com/apache/superset/commit/7af8b2b3f822d74094f09609cd7e740415f90354) why was the `<0.7` constraint applied — I preferred shipping a quick fix first. I will test bumping `[fb]prophet` instead, but if it passes test, I'd still appreciate some external sanity check as I couldn't do much more than blindly relying on them. P.S.: FYI, I'm currently testing it on https://github.com/EBoisseauSierra/superset/tree/bump-prophet > would you like to 'own' this piece and keep it in good shape going forward? Thanks for offering. I would be happy to monitor when Prophet fixes its dependency, to revert this change; yet I'm afraid I am not familiar enough with prophet to properly “own” the extension. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
