ktmud commented on a change in pull request #13871:
URL: https://github.com/apache/superset/pull/13871#discussion_r604287657



##########
File path: superset/examples/big_data.py
##########
@@ -68,3 +70,7 @@ def load_big_data() -> None:
     ]
     for i in range(1000):
         add_data(columns=columns, num_rows=10, table_name=f"small_table_{i}")
+
+    print("Creating table with long name")
+    name = "".join(random.choices(string.ascii_letters + string.digits, k=64))

Review comment:
       I think @amitmiran137 already create a `get_random_string` function in 
test utils: 
   
https://github.com/apache/superset/blob/9a7fba810e5bc3a94746117937163c1bfaea19ee/tests/dashboards/dashboard_test_utils.py#L99
   
   Maybe  consolidate?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to