willbarrett commented on a change in pull request #13894:
URL: https://github.com/apache/superset/pull/13894#discussion_r605196188
##########
File path: tests/reports/commands_tests.py
##########
@@ -750,6 +750,10 @@ def test_email_dashboard_report_fails(
)
@patch("superset.reports.notifications.email.send_email_smtp")
@patch("superset.utils.screenshots.ChartScreenshot.get_screenshot")
[email protected](
+ "superset.extensions.feature_flag_manager._feature_flags",
+ ALERTS_ATTACH_REPORTS=True,
Review comment:
Let's add some tests for the inverse so we have confidence that
everything works as expected with the feature flag disabled as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
