rusackas opened a new pull request #13905: URL: https://github.com/apache/superset/pull/13905
### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Oops! Erroneously merged this to a feature branch instead of master. Ugh. See https://github.com/apache/superset/pull/13884 for a history/comments, and prior approvals. A recent PR, #13723, made some changes around how the sidebar works for the native filter features. This looks great when the feature flag is on, but when the feature flag is off, we lose the left margin, as reported in #13863. This PR makes sure the styling is consistent, by considering feature flag setting, and only toggling off `dashboardFiltersOpen` (which sets the margin) when the feature is indeed enabled. @simcha90 if you have a more elegant way to tackle this, or ideas for sufficient testing to cover this possible regression, please let me know your thoughts. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> BEFORE (`DASHBOARD_NATIVE_FILTERS` set to False):  AFTER (`DASHBOARD_NATIVE_FILTERS` set to False):   AFTER (`DASHBOARD_NATIVE_FILTERS` set to True):  ### TEST PLAN <!--- What steps should be taken to verify the changes --> Verified that the margin is restored, in view and edit mode, with the `DASHBOARD_NATIVE_FILTERS` flag on and off. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: Fixes #13863 - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
