michael-s-molina commented on a change in pull request #13748:
URL: https://github.com/apache/superset/pull/13748#discussion_r605586322
##########
File path:
superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.jsx
##########
@@ -29,22 +29,19 @@ import {
validateNonEmpty,
} from '@superset-ui/core';
-import SelectControl from './SelectControl';
-import TextControl from './TextControl';
-import CheckboxControl from './CheckboxControl';
-
+import SelectControl from 'src/explore/components/controls/SelectControl';
+import TextControl from 'src/explore/components/controls/TextControl';
+import CheckboxControl from 'src/explore/components/controls/CheckboxControl';
Review comment:
No problem at all! 😄
> But it would be great if the linter enforced fully deterministic imports
(will try to poke around to see if this is possible/makes sense)
This would be awesome!
@villebro @rusackas I think that after
[SIP-61](https://github.com/apache/superset/issues/13632) we'll have a more
predictable structure, and that can allow us to use [Webpack module
aliases](https://webpack.js.org/configuration/resolve/) for our main folders
and help with full imports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
