AAfghahi commented on a change in pull request #13893: URL: https://github.com/apache/superset/pull/13893#discussion_r605734802
########## File path: superset/queries/saved_queries/commands/importers/v1/_init_.py ########## @@ -0,0 +1,90 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from typing import Any, Dict, Set + +from marshmallow import Schema +from sqlalchemy.orm import Session + +from supereset.queries.saved_queries.commands.exceptions import SavedQueryImportError +from superset.commands.importers.v1 import ImportModelsCommand +from superset.connectors.sqla.models import SqlaTable +from superset.databases.commands.importers.v1.utils import import_database +from superset.datasets.commands.importers.v1.utils import import_dataset +from superset.dataset.schemas import ImportV1DatasetSchema +from superset.queries.dao import SavedQueryDAO +from superset.queries.saved_queries.commands.importers.v1.utils import import_saved_query +from superset.queries.saved_queries.schemas import ImportV1SavedQuerySchema + +class ImportSavedQueriesCommand(ImportModelsCommand): + """Import Saved Queries""" + + dao = SavedQueryDAO + model_name= "saved_queries" + prefix ="saved_queries/" + schemas: Dict[str, Schema] = { + "datasets/": ImportV1DatasetSchema(), + "saved_query": ImportV1SavedQuerySchema(), + } + import_error = SavedQueryImportError + + @staticmethod + def _import( + session: Session, configs: Dict[str, Any], overwrite: bool = False + ) -> None: + # discover datasets associated with saved queries Review comment: ` def _import( session: Session, configs: Dict[str, Any], overwrite: bool = False ) -> None: # discover databases associated with saved queries dataset_uuids: Set[str] = set() for file_name, config in configs.items(): if file_name.startswith("queries/"): dataset_uuids.add(config["database_uuid"]) # import related databases database_ids: Dict[str, int] = {} for file_name, config in configs.items(): if file_name.startswith("databases/") and config["uuid"] in database_uuids: database = import_database(session, config, overwrite=False) database_ids[str(database.uuid)] = database.id # import saved queries with the correct parent ref for file_name, config in configs.items(): if file_name.startswith("queries/") and config["database_uuid"] in database: # update datasource id, type, and name database = database[config["dataset_uuid"]] config.update( { "datasource_id": database.id, "datasource_name": database.table_name, } ) config["params"].update({"datasource": database.uid}) import_saved_query(session, config, overwrite=overwrite)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
