ktmud commented on a change in pull request #13739:
URL: https://github.com/apache/superset/pull/13739#discussion_r605837670
##########
File path: superset/connectors/sqla/models.py
##########
@@ -873,7 +858,7 @@ def adhoc_metric_to_sqla(
if table_column:
sqla_column = table_column.get_sqla_col()
else:
- sqla_column = column(column_name)
+ sqla_column = table(self.table_name,
column(column_name)).c[column_name]
Review comment:
Hmm, this line is not actually in use anymore. I'll remove.
It was from a previous attempt to fix the bug with another solution (adding
table name prefixes to columns).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
