yardz commented on a change in pull request #13892: URL: https://github.com/apache/superset/pull/13892#discussion_r605841396
########## File path: superset-frontend/src/dashboard/components/PublishedStatus/PublishedStatus.test.tsx ########## @@ -0,0 +1,82 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import React from 'react'; +import { render, screen } from 'spec/helpers/testing-library'; +import userEvent from '@testing-library/user-event'; +import PublishedStatus from '.'; + +const defaultProps = { + dashboardId: 1, + isPublished: false, + savePublished: jest.fn(), + canEdit: false, + canSave: false, +}; + +test('renders with unpublished status and readonly permissions', async () => { + const tooltip = /This dashboard is not published which means it will not show up in the list of dashboards/; + render(<PublishedStatus {...defaultProps} />); + expect(screen.getByText('Draft')).toBeInTheDocument(); + userEvent.hover(screen.getByText('Draft')); + expect(await screen.findByText(tooltip)).toBeInTheDocument(); +}); + +test('renders with unpublished status and write permissions', async () => { + const tooltip = /This dashboard is not published, it will not show up in the list of dashboards/; + const savePublished = jest.fn(); + render( + <PublishedStatus + {...defaultProps} + canEdit + canSave + savePublished={savePublished} + />, + ); + expect(screen.getByText('Draft')).toBeInTheDocument(); + userEvent.hover(screen.getByText('Draft')); + expect(await screen.findByText(tooltip)).toBeInTheDocument(); + expect(savePublished).not.toHaveBeenCalled(); + userEvent.click(screen.getByText('Draft')); + expect(savePublished).toHaveBeenCalledTimes(1); +}); + +test('renders with published status and readonly permissions', () => { + render(<PublishedStatus {...defaultProps} isPublished />); + expect(screen.queryByText('Published')).not.toBeInTheDocument(); +}); + +test('renders with published status and write permissions', async () => { + const tooltip = /This dashboard is published. Click to make it a draft/; + const savePublished = jest.fn(); + render( + <PublishedStatus + {...defaultProps} + isPublished + canEdit + canSave + savePublished={savePublished} + />, + ); + expect(screen.getByText('Published')).toBeInTheDocument(); + userEvent.hover(screen.getByText('Published')); + expect(await screen.findByText(tooltip)).toBeInTheDocument(); + expect(savePublished).not.toHaveBeenCalled(); + userEvent.click(screen.getByText('Published')); + expect(savePublished).toHaveBeenCalledTimes(1); Review comment: Nice! (2) ########## File path: superset-frontend/src/dashboard/components/PublishedStatus/PublishedStatus.test.tsx ########## @@ -0,0 +1,82 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import React from 'react'; +import { render, screen } from 'spec/helpers/testing-library'; +import userEvent from '@testing-library/user-event'; +import PublishedStatus from '.'; + +const defaultProps = { + dashboardId: 1, + isPublished: false, + savePublished: jest.fn(), + canEdit: false, + canSave: false, +}; + +test('renders with unpublished status and readonly permissions', async () => { + const tooltip = /This dashboard is not published which means it will not show up in the list of dashboards/; + render(<PublishedStatus {...defaultProps} />); + expect(screen.getByText('Draft')).toBeInTheDocument(); + userEvent.hover(screen.getByText('Draft')); + expect(await screen.findByText(tooltip)).toBeInTheDocument(); +}); + +test('renders with unpublished status and write permissions', async () => { + const tooltip = /This dashboard is not published, it will not show up in the list of dashboards/; + const savePublished = jest.fn(); + render( + <PublishedStatus + {...defaultProps} + canEdit + canSave + savePublished={savePublished} + />, + ); + expect(screen.getByText('Draft')).toBeInTheDocument(); + userEvent.hover(screen.getByText('Draft')); + expect(await screen.findByText(tooltip)).toBeInTheDocument(); + expect(savePublished).not.toHaveBeenCalled(); + userEvent.click(screen.getByText('Draft')); + expect(savePublished).toHaveBeenCalledTimes(1); Review comment: Nice! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
