eschutho opened a new pull request #13927:
URL: https://github.com/apache/superset/pull/13927


   ### SUMMARY
   Fixes a bug where the caret wasn't opening/closing collapse tables in sql 
lab left toolbar
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   see ticket for before
   
   after: 
   
   
https://user-images.githubusercontent.com/5186919/113370757-8b920480-9319-11eb-86ef-f979f3de157d.mov
   
   
   ### TEST PLAN
   jest test added. For manual testing, you should be able to expand and 
collapse the tables by clicking on both the header and the icon. Existing 
functionality should remain, whereby adding a new table should automatically be 
expanded when it loads. 
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: https://github.com/apache/superset/issues/13903
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to