eschutho commented on a change in pull request #13822:
URL: https://github.com/apache/superset/pull/13822#discussion_r606049510
##########
File path: superset-frontend/src/SqlLab/components/SouthPane/SouthPane.tsx
##########
@@ -33,7 +33,8 @@ import {
LOCALSTORAGE_MAX_QUERY_AGE_MS,
} from '../../constants';
-const TAB_HEIGHT = 64;
+const TAB_HEIGHT = 90;
+const RESULTS_TAB_HEIGHT = TAB_HEIGHT - 10;
Review comment:
nice catch to make this a variable. But are they really related? Or is
it just coincidence that they are 10 pixels apart? If they are separate, I
would just say `RESULTS_TAB_HEIGH = 80;`
##########
File path: superset-frontend/src/SqlLab/components/SouthPane/SouthPane.tsx
##########
@@ -33,7 +33,8 @@ import {
LOCALSTORAGE_MAX_QUERY_AGE_MS,
} from '../../constants';
-const TAB_HEIGHT = 64;
+const TAB_HEIGHT = 90;
+const RESULTS_TAB_HEIGHT = TAB_HEIGHT - 10;
Review comment:
nice catch to make this a variable. But are they really related? Or is
it just coincidence that they are 10 pixels apart? If they are separate, I
would just say `RESULTS_TAB_HEIGHT = 80;`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
