nytai commented on a change in pull request #13939:
URL: https://github.com/apache/superset/pull/13939#discussion_r606387256
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
##########
@@ -104,17 +104,17 @@ export const FiltersConfigForm:
React.FC<FiltersConfigFormProps> = ({
.map(([key]) => key);
// @ts-ignore
- const hasDatasource = !!nativeFilterItems[formFilter?.filterType]?.value
+ const hasDataset = !!nativeFilterItems[formFilter?.filterType]?.value
?.datasourceCount;
const hasColumn =
- hasDatasource &&
+ hasDataset &&
!FILTERS_WITH_ONLY_DATASOURCE.includes(formFilter?.filterType);
const hasFilledDatasource =
Review comment:
should this one be updated too?
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
##########
@@ -271,7 +269,7 @@ export const FiltersConfigForm:
React.FC<FiltersConfigFormProps> = ({
forceUpdate();
}}
filterId={filterId}
- hasDatasource={hasDatasource}
+ hasDatasource={hasDataset}
Review comment:
also this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
