rusackas commented on a change in pull request #13887:
URL: https://github.com/apache/superset/pull/13887#discussion_r606429706
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Header.tsx
##########
@@ -98,10 +98,14 @@ const Header: FC<HeaderProps> = ({
<span>{t('Filters')}</span>
{canEdit && (
<FilterConfigurationLink createNewOnOpen={filterValues.length === 0}>
- <Icon name="edit" data-test="create-filter" />
+ <Icon name="edit" role="button" data-test="create-filter" />
</FilterConfigurationLink>
)}
- <Icon name="expand" onClick={() => toggleFiltersBar(false)} />
+ <Icon
+ name="expand"
+ role="button"
+ onClick={() => toggleFiltersBar(false)}
Review comment:
Is codecov correct that this is not being tested? If so, should we mock
that onClick?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
