hughhhh commented on a change in pull request #13946:
URL: https://github.com/apache/superset/pull/13946#discussion_r607263290
##########
File path: tests/datasets/api_tests.py
##########
@@ -598,12 +598,7 @@ def test_update_dataset_item_w_override_columns(self):
rv = self.put_assert_metric(uri, dataset_data, "put")
assert rv.status_code == 200
- columns = (
- db.session.query(TableColumn)
- .filter_by(table_id=dataset.id)
- .order_by("column_name")
- .all()
- )
+ columns =
db.session.query(TableColumn).filter_by(table_id=dataset.id).all()
Review comment:
yea, now with the refresh the new column appears in the front of the
array. So that is why I removed the order by
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
