hughhhh commented on pull request #13877: URL: https://github.com/apache/superset/pull/13877#issuecomment-813636481
> looks great! I rebased this recently and saw that an earlier commit had a few trims on database_name in the DatabaseModal file. Do we need to add those in? db.database_name.trim() Here's the PR if you want to make sure that they changes are represented here: #13800 (files) Those changes we need are currently on the branch already, the other `database_name` reference don't need to have `trim`. We can add them if want the consistency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
