geido commented on pull request #13945: URL: https://github.com/apache/superset/pull/13945#issuecomment-814136354
@simcha90 nice that you made `CategoricalColorNamespace` to work. I struggled to make it work when I attempted to solve this issue. However, I would like to point out that the system is still defective in a few ways. For the points below, design input will most likely be required. That's why I thought we had better chances to fix the functionality as a whole in the roadmap item https://github.com/apache-superset/superset-roadmap/issues/110 Defects: - When changing the label colors in the _Advanced - JSON Metadata_ the changes do not take effect immediately, even after saving. You must refresh the page to see the changes. - Any change made to a color scheme in the _Advanced - JSON Metadata_ will be lost when the user selects another color scheme, saves, and refreshes. I am not sure if this is intended to work this way, but it might be the case that a better user experience would be to persist those changes. CC @junlincc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
