simcha90 commented on a change in pull request #13726:
URL: https://github.com/apache/superset/pull/13726#discussion_r607870924
##########
File path:
superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
##########
@@ -115,18 +140,27 @@ export default function PluginFilterSelect(props:
PluginFilterSelectProps) {
};
useEffect(() => {
- handleChange(currentValue ?? []);
+ // For currentValue we need set always `FIRST_VALUE` only if we in config
modal for `defaultToFirstItem` mode
+ handleChange(
+ isDefaultToFirstItemInFilterConfigModal
+ ? FIRST_VALUE
+ : currentValue ?? [],
+ );
}, [
JSON.stringify(currentValue),
+ defaultToFirstItem,
Review comment:
I think no, because it's also relevant for a case when user had in
filter bar not first value, and then in filter modal changed it to firstValue
and clicked Save, so now it should be also updater in filter bar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
