graceguo-supercat commented on a change in pull request #11970:
URL: https://github.com/apache/superset/pull/11970#discussion_r608109640
##########
File path: superset/views/core.py
##########
@@ -650,6 +650,10 @@ def explore( # pylint:
disable=too-many-locals,too-many-return-statements
f"datasource_id={datasource_id}&"
)
+ # if feature enabled, run some health check rules for sqla datasource
+ if hasattr(datasource, "health_check"):
+ datasource.health_check()
Review comment:
We should run check _again_ when user updates dataset, or when health
check rule's version is changed. Otherwise the healthy status will not be
changed so we don't need to force run again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
