etr2460 commented on a change in pull request #13960:
URL: https://github.com/apache/superset/pull/13960#discussion_r608271456
##########
File path: tests/databases/api_tests.py
##########
@@ -820,7 +820,21 @@ def test_test_connection_failed(self):
self.assertEqual(rv.headers["Content-Type"], "application/json;
charset=utf-8")
response = json.loads(rv.data.decode("utf-8"))
expected_response = {
- "message": "Could not load database driver: BaseEngineSpec",
+ "errors": [
+ {
+ "message": "Could not load database driver:
BaseEngineSpec",
Review comment:
i guess ideally in the future these messages will become actual errors
with details on how to resolve them in the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
