etr2460 commented on a change in pull request #13979:
URL: https://github.com/apache/superset/pull/13979#discussion_r608320360
##########
File path: superset/dashboards/commands/importers/v1/utils.py
##########
@@ -115,7 +115,7 @@ def import_dashboard(
# TODO (betodealmeida): move this logic to import_from_dict
config = config.copy()
for key, new_name in JSON_KEYS.items():
- if config.get(key):
+ if config.get(key) is not None:
Review comment:
is `if key in config:` enough here?
basically, is the `is not None` test checking if `config.get` is returning
the default value, or if None is set in the config for that key?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
