[GitHub] [superset] michael-s-molina opened a new pull request #13989: refactor: Bootstrap to AntD - Slider

[GitBox]

michael-s-molina opened a new pull request #13989:
URL: https://github.com/apache/superset/pull/13989


   ### SUMMARY
   - Migrates the `Slider` component from Bootstrap to AntD
   - Creates a storybook entry for `Slider`
   - Removes `ReactBootstrapSlider`
   
   PS: No tests were added because we don't add any custom behavior to the 
component. Relying on AntD tests.
   
   See: #10254
   
   @mihir174 I didn't found the `Slider` component in the North Star 
specification so I used AntD default, which I think fits very well with our 
theme. Let me know if we need to change it.
   
   @rusackas @junlincc @pkdotson 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <img width="357" alt="Screen Shot 2021-04-07 at 8 41 49 AM" 
src="https://user-images.githubusercontent.com/70410625/113861779-f3af7300-977d-11eb-9e02-f5997bc70f22.png";>
   <img width="346" alt="Screen Shot 2021-04-07 at 8 58 19 AM" 
src="https://user-images.githubusercontent.com/70410625/113863005-80a6fc00-977f-11eb-8365-37c372fd0e46.png";>
   <img width="1024" alt="Screen Shot 2021-04-07 at 8 47 15 AM" 
src="https://user-images.githubusercontent.com/70410625/113861780-f4480980-977d-11eb-8606-ba2938be4bd2.png";>
   
   ### TEST PLAN
   1 - Execute all tests
   2 - All tests should pass
   3 - Additional testing can be done using Storybook
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org