amitmiran137 opened a new pull request #13992: URL: https://github.com/apache/superset/pull/13992
### SUMMARY This is the second milestone in dashboard_rbac support where having a dashboard role entitles the user data access to all of the datasets within a dashboard following @suddjian [recommendation](https://github.com/apache/superset/pull/13773#discussion_r606339199) on an existing PR, I decided to take a simpler solution ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF https://user-images.githubusercontent.com/47772523/113897597-b1b11c00-97d3-11eb-8bcf-6d1ed7b3406e.mov ### TEST PLAN 0. enable DASHBOARD_RBAC ff 1. create a separated user with Gamma role 2. on dashboard properties give Gamma role access to the dashboard 3. sign in as the gamma user 4. check that he can access the dashboard and all charts all loaded inside ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
