[GitHub] [superset] eschutho opened a new pull request #14009: fix: use dynamic time_grains for schema

[GitBox]

eschutho opened a new pull request #14009:
URL: https://github.com/apache/superset/pull/14009


   ### SUMMARY
   When testing out TIME_GRAIN_ADDONS from the config, although new time grains 
are working for line charts, they don't work for table charts:
   <img width="1504" alt="Explore_-_Untitled_Query_2_04_07_2021_18_50_18" 
src="https://user-images.githubusercontent.com/5186919/113958884-ae6b5f80-97d6-11eb-8265-7e6f924bd31c.png";>
   
   This PR uses the built in time grains from the db_engine_spec and adds the 
time_grain_addons from the config to make the schema fields for the charts
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   after: 
   <img width="1503" alt="Explore_-_Untitled_Query_2_04_07_2021_18_50_18" 
src="https://user-images.githubusercontent.com/5186919/113958938-cba02e00-97d6-11eb-8a08-47598e1ba633.png";>
   
   
   ### TEST PLAN
   I didn't see any unit tests for schemas. It's typically a very static file. 
I can add a new test if it feels warranted. Otherwise, to manually test, add a 
new time grain for the selected db and test with different types of charts. 
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org