thomasv314 opened a new pull request #14031:
URL: https://github.com/apache/superset/pull/14031


   ### SUMMARY
   Replaces the chart version with the helper function, which generates a 
string that fits within the metadata.labels regex validation
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   Verify the chart renders properly
   
   ### ADDITIONAL INFORMATION
   Our chart release/version process uses a semver2 pattern where the git ref 
is appended with a `+`. 
   
   By switching from the string interpolated format to the `superset.chart` 
template, it changes the rendered output from:
   
   ```
   labels:
     chart: superset-0.0.1+44068e96a # This is not a valid k8s resource label
   ```
   
   to:
   
   ```
   labels:
     chart: superset-0.0.1_44068e96a # Accepted by the k8s API, and used in all 
other chart resources
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to