etr2460 opened a new pull request #14040:
URL: https://github.com/apache/superset/pull/14040


   ### SUMMARY
   Thanks to @betodealmeida's work in 
https://github.com/apache/superset/pull/13960, it was pretty trivial to get the 
new chart data API returning the SIP-40 style error payloads. This PR also 
refactors the SupersetErrorException a bit to support passing in a 
SupersetError, naming help for the other exception type would be much 
appreciated.
   
   ### TEST PLAN
   New unit test, verify that the same error messages are returned when 
accessing data in a nvd3 line chart and the new table chart and pie chart.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   to: @betodealmeida @john-bodley @ktmud @graceguo-supercat 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to