michael-s-molina commented on a change in pull request #14027: URL: https://github.com/apache/superset/pull/14027#discussion_r610653170
########## File path: docs/src/pages/docs/Miscellaneous/index.mdx ########## @@ -6,89 +6,57 @@ index: 1 version: 1 --- -## Country Map Tools +## The Country Map Visualiaztion -This tool is used in slices for visualization number or string by region, province or department of -your countries. So, if you want to use tools, you need ISO 3166-2 code of region, province or -department. +The Country Map visualization allows you to plot lightweight choropleth maps of +your countries by province, states, or other subdivision types. It does not rely +on any third-party map services but would require you to provide the +[ISO-3166-2](https://en.wikipedia.org/wiki/ISO_3166-2) codes of your country's +top-level subdivisions. Comparing to a province or state's full names, the ISO +code is less ambiguous and is unique to all regions in the world. -ISO 3166-2 is part of the ISO 3166 standard published by the International Organization for -Standardization (ISO), and defines codes for identifying the principal subdivisions (e.g., provinces -or states) of all countries coded in ISO 3166-1 +## Included Maps -The purpose of ISO 3166-2 is to establish an international standard of short and unique alphanumeric -codes to represent the relevant administrative divisions and dependent territories of all countries -in a more convenient and less ambiguous form than their full names. Each complete ISO 3166-2 code -consists of two parts, separated by a hyphen: - -The first part is the ISO 3166-1 alpha-2 code of the country; The second part is a string of up to -three alphanumeric characters, which is usually obtained from national sources and stems from coding -systems already in use in the country concerned, but may also be developed by the ISO itself. - -We can apply these concepts to specify the state of Texas in the country of United States: - -``` -US-TX -``` - -### Included Codes - -The ISO codes for the following countries are included in Superset: +The Country Maps visualization already ships with the maps for following countries: Review comment: ```suggestion The Country Maps visualization already ships with the maps for the following countries: ``` ########## File path: docs/src/pages/docs/Miscellaneous/index.mdx ########## @@ -6,89 +6,57 @@ index: 1 version: 1 --- -## Country Map Tools +## The Country Map Visualiaztion -This tool is used in slices for visualization number or string by region, province or department of -your countries. So, if you want to use tools, you need ISO 3166-2 code of region, province or -department. +The Country Map visualization allows you to plot lightweight choropleth maps of +your countries by province, states, or other subdivision types. It does not rely +on any third-party map services but would require you to provide the +[ISO-3166-2](https://en.wikipedia.org/wiki/ISO_3166-2) codes of your country's +top-level subdivisions. Comparing to a province or state's full names, the ISO +code is less ambiguous and is unique to all regions in the world. -ISO 3166-2 is part of the ISO 3166 standard published by the International Organization for -Standardization (ISO), and defines codes for identifying the principal subdivisions (e.g., provinces -or states) of all countries coded in ISO 3166-1 +## Included Maps -The purpose of ISO 3166-2 is to establish an international standard of short and unique alphanumeric -codes to represent the relevant administrative divisions and dependent territories of all countries -in a more convenient and less ambiguous form than their full names. Each complete ISO 3166-2 code -consists of two parts, separated by a hyphen: - -The first part is the ISO 3166-1 alpha-2 code of the country; The second part is a string of up to -three alphanumeric characters, which is usually obtained from national sources and stems from coding -systems already in use in the country concerned, but may also be developed by the ISO itself. - -We can apply these concepts to specify the state of Texas in the country of United States: - -``` -US-TX -``` - -### Included Codes - -The ISO codes for the following countries are included in Superset: +The Country Maps visualization already ships with the maps for following countries: - Belgium +- Brazil +- Bulgaria +- Canada - China - Egypt - France - Germany +- India +- Iran +- Italy - Japan +- Korea - Liechtenstein - Morocco +- Myanmar +- Netherlands +- Portugal - Russia - Singapore - Spain - Switzerland -- United Kingdom +- Syria +- Thailand +- Timorleste +- Uk Review comment: ```suggestion - UK ``` ########## File path: docs/src/pages/docs/Miscellaneous/index.mdx ########## @@ -6,89 +6,57 @@ index: 1 version: 1 --- -## Country Map Tools +## The Country Map Visualiaztion -This tool is used in slices for visualization number or string by region, province or department of -your countries. So, if you want to use tools, you need ISO 3166-2 code of region, province or -department. +The Country Map visualization allows you to plot lightweight choropleth maps of +your countries by province, states, or other subdivision types. It does not rely +on any third-party map services but would require you to provide the +[ISO-3166-2](https://en.wikipedia.org/wiki/ISO_3166-2) codes of your country's +top-level subdivisions. Comparing to a province or state's full names, the ISO +code is less ambiguous and is unique to all regions in the world. -ISO 3166-2 is part of the ISO 3166 standard published by the International Organization for -Standardization (ISO), and defines codes for identifying the principal subdivisions (e.g., provinces -or states) of all countries coded in ISO 3166-1 +## Included Maps -The purpose of ISO 3166-2 is to establish an international standard of short and unique alphanumeric -codes to represent the relevant administrative divisions and dependent territories of all countries -in a more convenient and less ambiguous form than their full names. Each complete ISO 3166-2 code -consists of two parts, separated by a hyphen: - -The first part is the ISO 3166-1 alpha-2 code of the country; The second part is a string of up to -three alphanumeric characters, which is usually obtained from national sources and stems from coding -systems already in use in the country concerned, but may also be developed by the ISO itself. - -We can apply these concepts to specify the state of Texas in the country of United States: - -``` -US-TX -``` - -### Included Codes - -The ISO codes for the following countries are included in Superset: +The Country Maps visualization already ships with the maps for following countries: - Belgium +- Brazil +- Bulgaria +- Canada - China - Egypt - France - Germany +- India +- Iran +- Italy - Japan +- Korea - Liechtenstein - Morocco +- Myanmar +- Netherlands +- Portugal - Russia - Singapore - Spain - Switzerland -- United Kingdom +- Syria +- Thailand +- Timorleste +- Uk Review comment: I'm assuming that you're not talking about configuration values here, just listing the supported countries. If these are configuration values, can we change the text to clearly state that? ########## File path: docs/src/pages/docs/Miscellaneous/index.mdx ########## @@ -6,89 +6,57 @@ index: 1 version: 1 --- -## Country Map Tools +## The Country Map Visualiaztion Review comment: ```suggestion ## The Country Map Visualization ``` ########## File path: docs/src/pages/docs/Miscellaneous/index.mdx ########## @@ -6,89 +6,57 @@ index: 1 version: 1 --- -## Country Map Tools +## The Country Map Visualiaztion -This tool is used in slices for visualization number or string by region, province or department of -your countries. So, if you want to use tools, you need ISO 3166-2 code of region, province or -department. +The Country Map visualization allows you to plot lightweight choropleth maps of +your countries by province, states, or other subdivision types. It does not rely +on any third-party map services but would require you to provide the +[ISO-3166-2](https://en.wikipedia.org/wiki/ISO_3166-2) codes of your country's +top-level subdivisions. Comparing to a province or state's full names, the ISO +code is less ambiguous and is unique to all regions in the world. -ISO 3166-2 is part of the ISO 3166 standard published by the International Organization for -Standardization (ISO), and defines codes for identifying the principal subdivisions (e.g., provinces -or states) of all countries coded in ISO 3166-1 +## Included Maps -The purpose of ISO 3166-2 is to establish an international standard of short and unique alphanumeric -codes to represent the relevant administrative divisions and dependent territories of all countries -in a more convenient and less ambiguous form than their full names. Each complete ISO 3166-2 code -consists of two parts, separated by a hyphen: - -The first part is the ISO 3166-1 alpha-2 code of the country; The second part is a string of up to -three alphanumeric characters, which is usually obtained from national sources and stems from coding -systems already in use in the country concerned, but may also be developed by the ISO itself. - -We can apply these concepts to specify the state of Texas in the country of United States: - -``` -US-TX -``` - -### Included Codes - -The ISO codes for the following countries are included in Superset: +The Country Maps visualization already ships with the maps for following countries: - Belgium +- Brazil +- Bulgaria +- Canada - China - Egypt - France - Germany +- India +- Iran +- Italy - Japan +- Korea - Liechtenstein - Morocco +- Myanmar +- Netherlands +- Portugal - Russia - Singapore - Spain - Switzerland -- United Kingdom +- Syria +- Thailand +- Timorleste +- Uk - Ukraine -- USA - -### Adding New Countries +- Uruguay +- Usa Review comment: ```suggestion - USA ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
