amitmiran137 opened a new pull request #14076: URL: https://github.com/apache/superset/pull/14076
### SUMMARY As all things are so should sharing be a managed under a permission the user entitles to. can_share_dashboard and can_share_chart are the new permissions . both hide/show `ShareMenuItems` component on the dashboard/chart menus ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF https://user-images.githubusercontent.com/47772523/114314495-a166ad00-9b03-11eb-9b10-604056ee85e8.mov ### TEST PLAN 1. check that sharing is menu option is shown by default for Admin/Gamma/Alpha 2. remove can share chart/dashboard on Superset from you user role 3. check that sharing menu option is hidden ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
