hughhhh commented on a change in pull request #14076:
URL: https://github.com/apache/superset/pull/14076#discussion_r611990082
##########
File path:
superset-frontend/src/dashboard/components/SliceHeaderControls/index.jsx
##########
@@ -253,18 +254,20 @@ class SliceHeaderControls extends React.PureComponent {
</Menu.Item>
)}
- <ShareMenuItems
- url={getDashboardUrl(
- window.location.pathname,
- getActiveFilters(),
- componentId,
- )}
- copyMenuItemTitle={t('Copy chart URL')}
- emailMenuItemTitle={t('Share chart by email')}
- emailSubject={t('Superset chart')}
- addSuccessToast={addSuccessToast}
- addDangerToast={addDangerToast}
- />
+ {this.props.supersetCanShare && (
Review comment:
add this to line 183 decontruct `const` so you can just put
`supersetCanShare`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
