eschutho opened a new pull request #14092:
URL: https://github.com/apache/superset/pull/14092


   ### SUMMARY
   We're restyling the database modal to group together the different items 
into two tabs instead of 5 and try to make it simpler for people to create/edit 
a database. Next step will be eventually create a form where we can give people 
an option to not have to figure out what the sqlalchemy string should be, but 
rather we build it for them. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   After: 
   
   
https://user-images.githubusercontent.com/5186919/114476651-7df93c00-9baf-11eb-8987-85f8bcd3870b.mov
   
   
   
   ### TEST PLAN
   updated unit tests. Functionality should be the same. To test, open the 
modal by either editing or creating a new database.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to