villebro opened a new pull request #14095: URL: https://github.com/apache/superset/pull/14095
### SUMMARY The recent PR #13739 caused a regression causing mutated column aliases to be returned from the SQLAlchemy model in the resulting `DataFrame`. By setting the `key` parameter to the expected column name (https://docs.sqlalchemy.org/en/13/core/metadata.html#sqlalchemy.schema.Column.params.key), and later referencing that when renaming columns in the `DataFrame`, we can ensure that column names are mutated back prior to returning. ### BEFORE Currently column names containing restricted characters are returned. See the failed query and the column `COUNT_DISTINCT(str)` called `COUNT_DISTINCT__93439` in the Results tab):  ### AFTER After the change, the chart renders and the column names in the Results tab show the expected labels:  ### TEST PLAN CI + new test ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
