betodealmeida commented on a change in pull request #14064:
URL: https://github.com/apache/superset/pull/14064#discussion_r612790374
##########
File path: superset/databases/commands/create.py
##########
@@ -92,6 +92,9 @@ def validate(self) -> None:
exception = DatabaseInvalidError()
exception.add_list(exceptions)
event_logger.log_with_context(
- action=f"db_connection_failed.{exception.__class__.__name__}"
+ action="db_connection_failed.{}.{}".format(
+ exception.__class__.__name__,
+ ".".join(exception.get_list_classnames()),
Review comment:
Should we sort the list of class names, so that the exceptions with the
same classes get grouped together?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
