rusackas commented on a change in pull request #14035:
URL: https://github.com/apache/superset/pull/14035#discussion_r612850812
##########
File path: superset-frontend/src/addSlice/AddSliceContainer.tsx
##########
@@ -88,69 +95,63 @@ export default class AddSliceContainer extends
React.PureComponent<
render() {
return (
- <div className="container">
- <Panel>
- <Panel.Heading>
- <h3>{t('Create a new chart')}</h3>
- </Panel.Heading>
- <Panel.Body>
- <div>
- <p>{t('Choose a dataset')}</p>
- <div style={styleSelectContainer}>
- <Select
- clearable={false}
- ignoreAccents={false}
- name="select-datasource"
- onChange={this.changeDatasource}
- options={this.props.datasources}
- placeholder={t('Choose a dataset')}
- value={
- this.state.datasourceValue
- ? {
- value: this.state.datasourceValue,
- }
- : undefined
- }
- width={600}
- />
- </div>
- <span className="text-muted">
- {t(
- 'If the dataset you are looking for is not available in the
list, follow the instructions on how to add it in the Superset tutorial.',
- )}{' '}
- <a
-
href="https://superset.apache.org/docs/creating-charts-dashboards/first-dashboard#adding-a-new-table";
- rel="noopener noreferrer"
- target="_blank"
- >
- <i className="fa fa-external-link" />
- </a>
- </span>
- </div>
- <br />
- <div>
- <p>{t('Choose a visualization type')}</p>
- <VizTypeControl
- name="select-vis-type"
- onChange={this.changeVisType}
- value={this.state.visType}
- labelType="primary"
- />
- </div>
- <br />
- <hr />
- <Button
- buttonStyle="primary"
- disabled={this.isBtnDisabled()}
- onClick={this.gotoSlice}
+ <StyledContainer className="container">
Review comment:
I'm not sure if this className does anything... you might be able to get
rid of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
