ktmud commented on a change in pull request #14109:
URL: https://github.com/apache/superset/pull/14109#discussion_r614293497



##########
File path: superset/app.py
##########
@@ -551,6 +553,7 @@ def init_app(self) -> None:
         self.pre_init()
         # Configuration of logging must be done first to apply the formatter 
properly
         self.configure_logging()
+        self.configure_db_enc()

Review comment:
       ```suggestion
           self.configure_db_encrypt()
   ```
   
   Because `enc` can often be confused with `encoding`.

##########
File path: superset/config.py
##########
@@ -45,6 +45,7 @@
 from superset.stats_logger import DummyStatsLogger
 from superset.typing import CacheConfig
 from superset.utils.core import is_test
+from superset.utils.enc import SQLAlchemyUtilsAdapter

Review comment:
       ```suggestion
   from superset.utils.encrypt import SQLAlchemyUtilsAdapter
   ```
   
   Same as above




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to