michael-s-molina opened a new pull request #14174:
URL: https://github.com/apache/superset/pull/14174


   ### SUMMARY
   - Rewrites dashboard `IconButton` component with typescript and functional 
component
   - Replaces the icons with the official icons
   - Removes `buttons.less` file
   - Fixes dashboard builder row options. They were not appearing on the screen.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
https://user-images.githubusercontent.com/70410625/114943289-26133d00-9e1c-11eb-9367-bd620fc40e09.mov
   
   
https://user-images.githubusercontent.com/70410625/114943151-eea49080-9e1b-11eb-8089-34f159c35d8e.mov
   
   @rusackas @junlincc 
   
   ### TEST PLAN
   1 - Edit a dashboard
   2 - Check the configuration icons of the grid components
   3 - Check the delete button of each grid component
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to