michael-s-molina commented on pull request #14137: URL: https://github.com/apache/superset/pull/14137#issuecomment-821099704
> LGTM, needs rebase. > > This PR also makes me wonder if we couldn't add an `info` prop to the `Tooltip` and add the styling/features of `InfoTooltip` into `Tooltip` that way so that we don't need to maintain two components. You're totally right. I noticed that now that things are starting to be organized, it's easier to perceive duplicated components or merge-able ones. For me the best example of this is `CertifiedIcon`, `ChartIcon`, `FaveStar`, `IconTooltip`, `RefreshLabel`, `WarningIconWithTooltip`. They could all be merged into an Icon that can be clicked, selected, and have a tooltip. We'll get there in the second wave of refactoring. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
