ktmud commented on pull request #14109: URL: https://github.com/apache/superset/pull/14109#issuecomment-821265737
> The model class needs this config value to create the encrypted field, so there will be a dependency chain one way or another. The proposed change is about abstracting the config away outside of main models. Where to put the access to config doesn't really matter that much as long as it doesn't create circular imports. I agree the factory pattern is useful to some more complex extensions where you need to initialize a long-lasting class instance to hold various states, but this doesn't seem to be the case. I guess I'm just struggling to see what else could be added to the `EncryptedFieldTypeAdapter`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
