villebro commented on a change in pull request #14098:
URL: https://github.com/apache/superset/pull/14098#discussion_r616379489
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigModal.tsx
##########
@@ -35,6 +35,7 @@ import Footer from './Footer/Footer';
import FilterTabs from './FilterTabs';
import FiltersConfigForm from './FiltersConfigForm/FiltersConfigForm';
import { useOpenModal, useRemoveCurrentFilter } from './state';
+import { testWithId } from '../../../../utils/common';
Review comment:
nit:
```suggestion
import { testWithId } from 'src/utils/common';
```
##########
File path:
superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx
##########
@@ -55,6 +55,7 @@ import {
CustomFrame,
AdvancedFrame,
} from './components';
+import { testWithId } from '../../../../utils/common';
Review comment:
nit:
```suggestion
import { testWithId } from 'src/utils/common';
```
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterConfigurationLink/index.tsx
##########
@@ -38,14 +45,21 @@ export const FilterConfigurationLink: React.FC<FCBProps> =
({
}
async function submit(filterConfig: FilterConfiguration) {
- await dispatch(setFilterConfiguration(filterConfig));
+ dispatch(await setFilterConfiguration(filterConfig));
close();
}
return (
<>
{/* eslint-disable-next-line jsx-a11y/no-static-element-interactions */}
- <div onClick={() => setOpen(true)}>{children}</div>
Review comment:
Is the disable rule above still needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
