etr2460 commented on a change in pull request #14147:
URL: https://github.com/apache/superset/pull/14147#discussion_r616891104
##########
File path: superset/errors.py
##########
@@ -47,6 +47,7 @@ class SupersetErrorType(str, Enum):
CONNECTION_HOST_DOWN_ERROR = "CONNECTION_HOST_DOWN_ERROR"
CONNECTION_ACCESS_DENIED_ERROR = "CONNECTION_ACCESS_DENIED_ERROR"
CONNECTION_UNKNOWN_DATABASE_ERROR = "CONNECTION_UNKNOWN_DATABASE_ERROR"
+ CONNECTION_DATABASE_PERMISSIONS_ERROR =
"TEST_CONNECTION_DATABASE_PERMISSIONS_ERROR"
Review comment:
typically it's good to keep the enum name and the value consistent. It's
easier to track throughout the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
