betodealmeida opened a new pull request #14252:
URL: https://github.com/apache/superset/pull/14252
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
The Databricks DB engine is based on the Hive DB engine spec, but the result
from `SHOW FUNCTIONS` is slightly different. In Hive it returns a single column
called `tab_name`, while in Databricks it's called `function`.
I changed the `get_function_names` method to allow derived classes to
specify a different column name, and also made it more resilient by accepting
any column name when only one column is returned.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
N/A
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
I tested the response from both Hive and Databricks, and also tested that it
works when the results have a single column with a name different than the one
expected (in that case we still log an error, but return the names).
Response from Databricks with this PR:
```
{
"function_names": [
"!",
"!=",
"%",
"&",
"*",
"+",
"-",
"/",
"<",
"<=",
"<=>",
"<>",
"=",
"==",
">",
">=",
"^",
"abs",
"acos",
"acosh",
"add_months",
"aggregate",
"and",
"any",
"approx_count_distinct",
"approx_percentile",
"array",
"array_contains",
"array_distinct",
"array_except",
"array_intersect",
"array_join",
"array_max",
"array_min",
"array_position",
"array_remove",
"array_repeat",
"array_sort",
"array_union",
"arrays_overlap",
"arrays_zip",
"ascii",
"asin",
"asinh",
"assert_true",
"atan",
"atan2",
"atanh",
"avg",
"base64",
"between",
"bigint",
"bin",
"binary",
"bit_and",
"bit_count",
"bit_length",
"bit_or",
"bit_xor",
"bool_and",
"bool_or",
"boolean",
"bround",
"cardinality",
"case",
"cast",
"cbrt",
"ceil",
"ceiling",
"char",
"char_length",
"character_length",
"charindex",
"chr",
"coalesce",
"collect_list",
"collect_set",
"concat",
"concat_ws",
"conv",
"corr",
"cos",
"cosh",
"cot",
"count",
"count_if",
"count_min_sketch",
"covar_pop",
"covar_samp",
"crc32",
"cube",
"cume_dist",
"current_database",
"current_date",
"current_timestamp",
"current_user",
"date",
"date_add",
"date_format",
"date_part",
"date_sub",
"date_trunc",
"datediff",
"day",
"dayofmonth",
"dayofweek",
"dayofyear",
"decimal",
"decode",
"degrees",
"dense_rank",
"div",
"double",
"e",
"element_at",
"elt",
"encode",
"every",
"exists",
"exp",
"explode",
"explode_outer",
"expm1",
"extract",
"factorial",
"filter",
"find_in_set",
"first",
"first_value",
"flatten",
"float",
"floor",
"forall",
"format_number",
"format_string",
"from_csv",
"from_json",
"from_unixtime",
"from_utc_timestamp",
"get_json_object",
"greatest",
"grouping",
"grouping_id",
"hash",
"hex",
"hour",
"hypot",
"if",
"iff",
"ifnull",
"in",
"initcap",
"inline",
"inline_outer",
"input_file_block_length",
"input_file_block_start",
"input_file_name",
"instr",
"int",
"is_member",
"isnan",
"isnotnull",
"isnull",
"java_method",
"json_tuple",
"kurtosis",
"lag",
"last",
"last_day",
"last_value",
"lcase",
"lead",
"least",
"left",
"length",
"levenshtein",
"like",
"ln",
"locate",
"log",
"log10",
"log1p",
"log2",
"lower",
"lpad",
"ltrim",
"make_date",
"make_interval",
"make_timestamp",
"map",
"map_concat",
"map_entries",
"map_filter",
"map_from_arrays",
"map_from_entries",
"map_keys",
"map_values",
"map_zip_with",
"max",
"max_by",
"md5",
"mean",
"min",
"min_by",
"minute",
"mod",
"monotonically_increasing_id",
"month",
"months_between",
"named_struct",
"nanvl",
"negative",
"next_day",
"not",
"now",
"ntile",
"nullif",
"nvl",
"nvl2",
"octet_length",
"or",
"overlay",
"parse_url",
"percent_rank",
"percentile",
"percentile_approx",
"pi",
"pmod",
"posexplode",
"posexplode_outer",
"position",
"positive",
"pow",
"power",
"printf",
"quarter",
"radians",
"rand",
"randn",
"random",
"rank",
"reduce",
"reflect",
"regexp_extract",
"regexp_replace",
"repeat",
"replace",
"reverse",
"right",
"rint",
"rlike",
"rollup",
"round",
"row_number",
"rpad",
"rtrim",
"schema_of_csv",
"schema_of_json",
"second",
"sentences",
"sequence",
"sha",
"sha1",
"sha2",
"shiftleft",
"shiftright",
"shiftrightunsigned",
"shuffle",
"sign",
"signum",
"sin",
"sinh",
"size",
"skewness",
"slice",
"smallint",
"some",
"sort_array",
"soundex",
"space",
"spark_partition_id",
"split",
"sql_dw_from_utc_timestamp",
"sql_dw_to_utc_timestamp",
"sqrt",
"stack",
"std",
"stddev",
"stddev_pop",
"stddev_samp",
"str_to_map",
"string",
"struct",
"substr",
"substring",
"substring_index",
"sum",
"tan",
"tanh",
"timestamp",
"tinyint",
"to_csv",
"to_date",
"to_json",
"to_timestamp",
"to_unix_timestamp",
"to_utc_timestamp",
"transform",
"transform_keys",
"transform_values",
"translate",
"trim",
"trunc",
"typeof",
"ucase",
"unbase64",
"unhex",
"unix_timestamp",
"upper",
"uuid",
"var_pop",
"var_samp",
"variance",
"version",
"weekday",
"weekofyear",
"when",
"width_bucket",
"window",
"xpath",
"xpath_boolean",
"xpath_double",
"xpath_float",
"xpath_int",
"xpath_long",
"xpath_number",
"xpath_short",
"xpath_string",
"xxhash64",
"year",
"zip_with",
"|",
"~"
]
}
```
Response from Hive:
```
{
"function_names": [
"!",
"!=",
"$sum0",
"%",
"&",
"*",
"+",
"-",
"/",
"<",
"<=",
"<=>",
"<>",
"=",
"==",
">",
">=",
"^",
"abs",
"acos",
"add_months",
"aes_decrypt",
"aes_encrypt",
"and",
"array",
"array_contains",
"ascii",
"asin",
"assert_true",
"atan",
"avg",
"base64",
"between",
"bin",
"bloom_filter",
"bround",
"cardinality_violation",
"case",
"cbrt",
"ceil",
"ceiling",
"char_length",
"character_length",
"chr",
"coalesce",
"collect_list",
"collect_set",
"compute_stats",
"concat",
"concat_ws",
"context_ngrams",
"conv",
"corr",
"cos",
"count",
"covar_pop",
"covar_samp",
"crc32",
"create_union",
"cume_dist",
"current_database",
"current_date",
"current_timestamp",
"current_user",
"date_add",
"date_format",
"date_sub",
"datediff",
"day",
"dayofmonth",
"dayofweek",
"decode",
"degrees",
"dense_rank",
"div",
"e",
"elt",
"encode",
"ewah_bitmap",
"ewah_bitmap_and",
"ewah_bitmap_empty",
"ewah_bitmap_or",
"exp",
"explode",
"extract_union",
"factorial",
"field",
"find_in_set",
"first_value",
"floor",
"floor_day",
"floor_hour",
"floor_minute",
"floor_month",
"floor_quarter",
"floor_second",
"floor_week",
"floor_year",
"format_number",
"from_unixtime",
"from_utc_timestamp",
"get_json_object",
"get_splits",
"greatest",
"grouping",
"hash",
"hex",
"histogram_numeric",
"hour",
"if",
"in",
"in_bloom_filter",
"in_file",
"index",
"initcap",
"inline",
"instr",
"internal_interval",
"isnotnull",
"isnull",
"java_method",
"json_tuple",
"lag",
"last_day",
"last_value",
"lcase",
"lead",
"least",
"length",
"levenshtein",
"like",
"ln",
"locate",
"log",
"log10",
"log2",
"logged_in_user",
"lower",
"lpad",
"ltrim",
"map",
"map_keys",
"map_values",
"mask",
"mask_first_n",
"mask_hash",
"mask_last_n",
"mask_show_first_n",
"mask_show_last_n",
"matchpath",
"max",
"md5",
"min",
"minute",
"mod",
"month",
"months_between",
"named_struct",
"negative",
"next_day",
"ngrams",
"noop",
"noopstreaming",
"noopwithmap",
"noopwithmapstreaming",
"not",
"ntile",
"nullif",
"nvl",
"octet_length",
"or",
"parse_url",
"parse_url_tuple",
"percent_rank",
"percentile",
"percentile_approx",
"pi",
"pmod",
"posexplode",
"positive",
"pow",
"power",
"printf",
"quarter",
"radians",
"rand",
"rank",
"reflect",
"reflect2",
"regexp",
"regexp_extract",
"regexp_replace",
"regr_avgx",
"regr_avgy",
"regr_count",
"regr_intercept",
"regr_r2",
"regr_slope",
"regr_sxx",
"regr_sxy",
"regr_syy",
"repeat",
"replace",
"replicate_rows",
"reverse",
"rlike",
"round",
"row_number",
"rpad",
"rtrim",
"second",
"sentences",
"sha",
"sha1",
"sha2",
"shiftleft",
"shiftright",
"shiftrightunsigned",
"sign",
"sin",
"size",
"sort_array",
"sort_array_by",
"soundex",
"space",
"split",
"sq_count_check",
"sqrt",
"stack",
"std",
"stddev",
"stddev_pop",
"stddev_samp",
"str_to_map",
"struct",
"substr",
"substring",
"substring_index",
"sum",
"tan",
"to_date",
"to_unix_timestamp",
"to_utc_timestamp",
"translate",
"trim",
"trunc",
"ucase",
"unbase64",
"unhex",
"unix_timestamp",
"upper",
"uuid",
"var_pop",
"var_samp",
"variance",
"version",
"weekofyear",
"when",
"windowingtablefunction",
"xpath",
"xpath_boolean",
"xpath_double",
"xpath_float",
"xpath_int",
"xpath_long",
"xpath_number",
"xpath_short",
"xpath_string",
"year",
"|",
"~"
]
}
```
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
